Messages in this thread | | | Date | Fri, 29 May 2015 08:45:08 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf tools: Make Ctrl-C stop processing on TUI |
| |
* Namhyung Kim <namhyung@kernel.org> wrote:
> It was inconvenient that perf cannot be quit with SIGINT during > processing samples on TUI especially for large data files. > > This was because the first argument of SLang_init_tty(), abort_char, > being 0. The manual says it's the ascii value of the control > character that will be used to generate the interrupt signal [1]. > Passing -1 means to use the default value (Ctrl-C). > > [1] http://jedsoft.org/slang/doc/html/cslang-6.html#ss6.1 > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/ui/tui/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/ui/tui/setup.c b/tools/perf/ui/tui/setup.c > index b77e1d771363..60d1f29b4b50 100644 > --- a/tools/perf/ui/tui/setup.c > +++ b/tools/perf/ui/tui/setup.c > @@ -129,7 +129,7 @@ int ui__init(void) > err = SLsmg_init_smg(); > if (err < 0) > goto out; > - err = SLang_init_tty(0, 0, 0); > + err = SLang_init_tty(-1, 0, 0); > if (err < 0) > goto out;
Will this change the current Ctrl-C behavior in other places in any way?
Right now Ctrl-C behavior is pretty sensible: it essentially means instant abort of whatever was done, i.e. stepping back a level in 'perf top', exit the app if it's done at the highest level. I hope that's preserved! :-)
Thanks,
Ingo
| |