lkml.org 
[lkml]   [2015]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path
    From
    Date
    Hi Vladimir,

    Am Freitag, den 29.05.2015, 14:31 +0300 schrieb Vladimir Zapolskiy:
    [...]
    > > res->start is of type phys_addr_t (well, resource_size_t) already.
    > > block->start/size and cur_start/size are just offsets added to it.
    >
    > I agree.
    >
    > > I wonder if it wouldn't be more appropriate to use resource_size_t for
    > > the sram_reserve .start field.
    >
    > Assuming that the sram_reserve .start field represents only the difference
    > of two res->start and this difference fits into u32 storage, it should be
    > safe to keep it as is.
    >
    > In my opinion integer overflow case should not be considered or handled
    > by the driver, so probably the best option would be just to drop
    > phys_addr_t commit, since it attempts to solve a nonexistent problem.
    >
    > Please let me know your opinion, if it is fine with you, I'll remove
    > "use phys_addr_t instead of u32 for physical address" commit and resend
    > the series.

    Yes, that's fine with me.

    regards
    Philipp



    \
     
     \ /
      Last update: 2015-05-29 18:21    [W:3.788 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site