Messages in this thread | | | Date | Fri, 29 May 2015 12:13:22 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tools: introduce arm64 support unwind test. |
| |
Em Fri, May 29, 2015 at 04:40:24PM +0200, Jiri Olsa escreveu: > On Fri, May 29, 2015 at 10:32:55AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, May 29, 2015 at 11:21:19AM +0200, Jiri Olsa escreveu: > > > On Thu, May 28, 2015 at 10:43:14AM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Thu, May 28, 2015 at 03:17:26PM +0800, Wangnan (F) escreveu: > > > > > Ping? > > > > > > Jiri, Ack? > > > > > yep, I've already ack-ed that.. should be on the lkml somewhere ;-) > > > > > > And from a quick look, isn't this better split in two pieces, i.e. the > > > > first wiring up ARM64 to libunwing, i.e. all those perf_regs.h files > > > > being added to tools/perf/arch/arm64/, and then a second patch, enabling > > > > the dwarf unwind 'perf test' entry to run on ARM64? > > > > > I guess.. but the change is fairly small, so it did not occur > > > to me as necessary.. > > > > :-) > > > > I felt mislead when looking at the subject, i.e. "hey, a new test, > > testing unwind on arm64", no, it wasn't that, it introduces support for > > unwind on ARM64 by providing that regs mapping, then it _enables_ an > > existing test on arm64 :-\ > > still it's good news right? ;-)
Whatever, I'll fix at least the cset log message and apply...
- Arnaldo
| |