Messages in this thread | | | Date | Fri, 29 May 2015 11:13:15 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 04/10] perf, tools: Handle header line in mapfile |
| |
On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: > Jiri Olsa [jolsa@redhat.com] wrote: > | > if (line[0] == '#' || line[0] == '\n') > | > continue; > | > + if (!strncmp(line, "Family", 6)) > | > + continue; > | > | I think we should fix mapfiles to put the 'Family' starting > | line as a comment.. the way powerpc mapfile is done > > You mean add something like this to the Intel mapfile: > > # Power8 entries > 004d0100,1,power8.json,core > > and drop this patch?
right
jirka
| |