lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/15] ia64: don't use module_init for non-modular core kernel/mca.c code
    Date
    The mca.c code is always built in.  It will never be modular,
    so using module_init as an alias for __initcall is rather
    misleading.

    Fix this up now, so that we can relocate module_init from
    init.h into module.h in the future. If we don't do this, we'd
    have to add module.h to obviously non-modular code, and that
    would be a worse thing.

    Direct use of __initcall is discouraged, vs prioritized ones.
    Use of device_initcall is consistent with what __initcall
    maps onto, and hence does not change the init order, making the
    impact of this change zero. Should someone with real hardware
    for boot testing want to change it later to arch_initcall or
    something different, they can do that at a later date.

    Cc: Tony Luck <tony.luck@intel.com>
    Cc: Fenghua Yu <fenghua.yu@intel.com>
    Cc: linux-ia64@vger.kernel.org
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    arch/ia64/sn/kernel/mca.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/arch/ia64/sn/kernel/mca.c b/arch/ia64/sn/kernel/mca.c
    index 27793f7aa99c..5b799d4deb74 100644
    --- a/arch/ia64/sn/kernel/mca.c
    +++ b/arch/ia64/sn/kernel/mca.c
    @@ -142,5 +142,4 @@ static int __init sn_salinfo_init(void)
    salinfo_platform_oemdata = &sn_salinfo_platform_oemdata;
    return 0;
    }
    -
    -module_init(sn_salinfo_init)
    +device_initcall(sn_salinfo_init);
    --
    2.2.1


    \
     
     \ /
      Last update: 2015-05-29 03:21    [W:4.094 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site