lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown
On Thu, May 28, 2015 at 02:45:14PM +0100, Richard Fitzgerald wrote:

> +#define ADSP2_SCRATCH0 0x40
> +#define ADSP2_SCRATCH1 0x41
> +#define ADSP2_SCRATCH2 0x42
> +#define ADSP2_SCRATCH3 0x43

May as well dump the other scratches while you're at it?

> + unsigned int scratch1 = 0xFFFFFFFF;

Why is this being initialized?

> - adsp_dbg(dsp, "Shutdown complete\n");
> + adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);

That seems a bit loud for a diagnostic message, why raise the severity?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-05-28 16:21    [W:1.463 / U:2.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site