lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] clockevents: timer-stm32: Fix build warning spotted by kbuild test robot
From
2015-05-28 0:52 GMT+02:00 Luc Van Oostenryck <luc.vanoostenryck@gmail.com>:
> On Wed, May 27, 2015 at 06:41:23PM +0200, Maxime Coquelin wrote:
>>
>> /* Detect whether the timer is 16 or 32 bits */
>> - writel_relaxed(~0UL, data->base + TIM_ARR);
>> + writel_relaxed((u32)~0UL, data->base + TIM_ARR);
>> max_delta = readl_relaxed(data->base + TIM_ARR);
>> if (max_delta == ~0UL) {
>> prescaler = 1;
>
>
> Since the warning come from using a unsigned long constant while
> writel() expect an unsigned int, why not simply use ~0U ?

You are right, this is indeed the right fix.
I'm sending the v2 now, using ~0U.

Thanks,
Maxime


\
 
 \ /
  Last update: 2015-05-28 07:21    [W:0.057 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site