Messages in this thread | | | Date | Thu, 28 May 2015 10:51:24 +0200 | From | Christoph Hellwig <> | Subject | Re: [GIT PULL v4 00/21] libnd: non-volatile memory device support |
| |
On Wed, May 27, 2015 at 06:24:42PM -0400, Dan Williams wrote: > Jens, please pull from... > > git://git.kernel.org/pub/scm/linux/kernel/git/djbw/nvdimm tags/libnd-for-jens
I don't really think it's quite ready. I don't have time to sort through the giant steaming pile for now, but there are a few things here:
- stong NAK for the linker wrapping abuse in the test module - you must run the ioctls past the linux-api list at least - please make sure the legacy e820 changes are properly tested. I could take of it, but not until Wednesday next week as I'm travelling right now.
Also a little nitpick on naming: why is this still nd instead of the widely used nvdimm? Also as very little of it is related to block drivers and a lot is management it should be under drivers/ not drivers/block/ I think.
| |