lkml.org 
[lkml]   [2015]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable
From
Date
On Thu, 2015-05-28 at 06:10 +0000, Harisangam, Sharvari (S.) wrote:
> Modified the if-else statements to remove unnecessary comparisons.
> This change was detected with the help of coccinelle tool

Your commit subject implies you are doing this for the
directory, not a single file.

If you are going to do this, please do it for all files
in the directory.

$ git grep -w -E "if\s*\(.*(true|false)" drivers/staging/vt6655/
drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == true)
drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true) {
drivers/staging/vt6655/card.c: if (pDevice->bHWRadioOff == true)
drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true)
drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == false) {
drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */
drivers/staging/vt6655/rxtx.c: if (bRTS == true) {
drivers/staging/vt6655/rxtx.c: if (bRTS == true) { /* RTS_need */




\
 
 \ /
  Last update: 2015-05-28 10:41    [W:0.079 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site