Messages in this thread | | | Subject | Re: [PATCH] Staging: vt6655: Remove unnecessary equality checks for a bool variable | From | Joe Perches <> | Date | Thu, 28 May 2015 01:15:40 -0700 |
| |
On Thu, 2015-05-28 at 06:10 +0000, Harisangam, Sharvari (S.) wrote: > Modified the if-else statements to remove unnecessary comparisons. > This change was detected with the help of coccinelle tool
Your commit subject implies you are doing this for the directory, not a single file.
If you are going to do this, please do it for all files in the directory.
$ git grep -w -E "if\s*\(.*(true|false)" drivers/staging/vt6655/ drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == true) drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true) { drivers/staging/vt6655/card.c: if (pDevice->bHWRadioOff == true) drivers/staging/vt6655/card.c: if (pDevice->bRadioControlOff == true) drivers/staging/vt6655/card.c: if (pDevice->bRadioOff == false) { drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */ drivers/staging/vt6655/rxtx.c: if (bRTS == true) {/* RTS_need */ drivers/staging/vt6655/rxtx.c: if (bRTS == true) { drivers/staging/vt6655/rxtx.c: if (bRTS == true) { /* RTS_need */
| |