Messages in this thread | | | Date | Wed, 27 May 2015 21:36:06 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH] block: fix returnvar.cocci warnings |
| |
On 05/26/2015 03:59 PM, Julia Lawall wrote: > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > One could check whether the ret variable was intended to be used for > anything.
Which tree is this against?
Linus's latest tree still has this in _submit_bh (unless git didn't pull the latest updates right):
if (buffer_meta(bh)) rw |= REQ_META; if (buffer_prio(bh)) rw |= REQ_PRIO;
bio_get(bio); submit_bio(rw, bio);
if (bio_flagged(bio, BIO_EOPNOTSUPP)) ret = -EOPNOTSUPP;
bio_put(bio); return ret; }
-- All rights reversed
| |