Messages in this thread | | | Date | Wed, 27 May 2015 08:18:31 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint |
| |
At Wed, 27 May 2015 05:38:01 +0000, Jie, Yang wrote: > > > -----Original Message----- > > From: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com] > > Sent: Wednesday, May 27, 2015 12:50 PM > > To: Jie, Yang > > Cc: tiwai@suse.de; broonie@kernel.org; alsa-devel@alsa-project.org; linux- > > kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > > footprint > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which > > > can save about 9KB memory size for reducing memory footprint purpose. > > > --- > > missing Signed-off-by. > > Thanks for pointing out. > > Signed-off-by: Jie Yang <yang.jie@intel.com> > > Takashi, do I need to resend them?
Yes, but you seen to have missed my first comment. Here again:
================================================================ > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > + bool "Reduced Memory Footprint Support" > + default n > + help > + Say 'Y' to enable Reduced Memory Footprint Support, which may > + reduce code size and data footprint as much as possible.
I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. ================================================================
And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS.
SND_PROC_FS bool "Sound proc file" if EXPERT depends on PROC_FS ....
Takashi
| |