Messages in this thread | | | From | "Simmons, James A." <> | Subject | RE: [lustre-devel] [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c | Date | Wed, 27 May 2015 21:04:01 +0000 |
| |
>> > >> >Don't split string literals, it makes them hard to grep for. >> >> Will fix. The CWARN will go over 80 characters but from the recent emails that is more acceptable. >> If this is the only problem then this patch set it ready. > >Normally the right thing to do here would be to send a fixed >[patch 5/6 v2] using the --in-reply-to option so that it appears as a >reply to the original [patch 5/6].
Made a note of that for future reference.
>> I have more patch series that are dependent >> on this first one. Should I push the other patch series with a note that it is dependent on the tcpip >> cleanup or wait until it is merged? Also how does one find out when the patch has been merged? > >You will get an email when these are merged. > >This is the only issue, I had. No one else has complained so that means >no one else has any objections. Greg hasn't merged it yet and he might >find a problem with it, but it seems like a straight forward patchset >so that's unlikely.
Ugh. I was off by one for the number of patches so I need to send a new batch.
>The only issue is that this patchset was sent in a confusing way. It >doesn't have a v2 tag and it was tacked on to the old thread. Greg >tends to not waste time being confused and just deletes the whole thread >when that happens.
Forgot to change the patch tag number. I will send a new batch with v2 so it is a new thread.
| |