lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: [PATCH] staging: gdm72xx: remove unneeded test
    From
    On Wed, May 27, 2015 at 5:25 PM, Laurent Navet <laurent.navet@gmail.com> wrote:
    > The same code is executed regardless ret value, so this test can be
    > removed.
    >
    > Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
    > ---
    > drivers/staging/gdm72xx/usb_boot.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/staging/gdm72xx/usb_boot.c b/drivers/staging/gdm72xx/usb_boot.c
    > index 3ccc447..7f80553 100644
    > --- a/drivers/staging/gdm72xx/usb_boot.c
    > +++ b/drivers/staging/gdm72xx/usb_boot.c
    > @@ -255,8 +255,6 @@ static int em_wait_ack(struct usb_device *usbdev, int send_zlp)
    >
    > /*Wait for ACK*/
    > ret = gdm_wibro_recv(usbdev, &ack, sizeof(ack));
    > - if (ret < 0)
    > - goto out;
    > out:
    > return ret;
    > }

    What about removing the 'out' label like this?

    --- a/drivers/staging/gdm72xx/usb_boot.c
    +++ b/drivers/staging/gdm72xx/usb_boot.c
    @@ -250,15 +250,11 @@ static int em_wait_ack(struct usb_device *usbdev, int send
    /*Send ZLP*/
    ret = gdm_wibro_send(usbdev, NULL, 0);
    if (ret < 0)
    - goto out;
    + return ret;
    }

    /*Wait for ACK*/
    - ret = gdm_wibro_recv(usbdev, &ack, sizeof(ack));
    - if (ret < 0)
    - goto out;
    -out:
    - return ret;
    + return gdm_wibro_recv(usbdev, &ack, sizeof(ack));
    }

    \
     
     \ /
      Last update: 2015-05-27 23:21    [W:3.095 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site