Messages in this thread | | | Date | Wed, 27 May 2015 12:15:21 -0700 | From | Brian Norris <> | Subject | Re: [PATCH] mtd: blktrans: use better error code for unimplemented ioctl() |
| |
On Thu, May 21, 2015 at 10:54:31AM -0700, Brian Norris wrote: > In commit 50183936254b ("mtd: blktrans: change blktrans_getgeo return > value") we fixed the problem that ioctl(HDIO_GETGEO) might return 0 > (success) for mtdblock devices which did not implement the feature and > would leave a blank (zero) result. > > But now, let's get the error code right. Other code paths on this ioctl > tend to use -ENOTTY to notify the user that the ioctl() is not supported > for the device, so let's use that instead of -EOPNOTSUPP. > > Suggested-by: Richard Weinberger <richard@nod.at> > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > --- > Against l2-mtd.git (linux-next)
Applied.
| |