lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.
Hi,

On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
> pcf8563->voltage_low = 1;
> dev_info(&client->dev,

Aren't dev_err or dev_warn more appropriate? You used dev_err in your
first patch, what made you change your mind?

> "low voltage detected, date/time is not reliable.\n");
> + return -EINVAL;
> }
>
> dev_dbg(&client->dev,

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


\
 
 \ /
  Last update: 2015-05-27 21:41    [W:0.071 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site