Messages in this thread | | | Date | Wed, 27 May 2015 20:53:52 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time. |
| |
Hi,
On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote : > @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm) > pcf8563->voltage_low = 1; > dev_info(&client->dev,
Aren't dev_err or dev_warn more appropriate? You used dev_err in your first patch, what made you change your mind?
> "low voltage detected, date/time is not reliable.\n"); > + return -EINVAL; > } > > dev_dbg(&client->dev,
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |