Messages in this thread | | | Date | Wed, 27 May 2015 19:28:46 +0200 | From | Andreas Färber <> | Subject | Re: [PATCH v4 2/2] soc: Add driver for Freescale Vybrid Platform |
| |
Hi,
Am 27.05.2015 um 15:07 schrieb maitysanchayan@gmail.com: > On 15-05-27 09:31:50, Paul Bolle wrote: >> On Tue, 2015-05-26 at 17:06 +0530, Sanchayan Maity wrote: >>> --- /dev/null >>> +++ b/drivers/soc/fsl/Kconfig >> >>> +config SOC_VF610 >>> + bool "SoC bus device for the Freescale Vybrid platform" >>> + select SOC_BUS >>> + help >>> + Include support for the SoC bus on the Freescale Vybrid platform >>> + providing some sysfs information about the module variant. >>> \ No newline at end of file [...] >>> --- /dev/null >>> +++ b/drivers/soc/fsl/Makefile >> >>> +obj-$(CONFIG_SOC_VF610) += soc-vf610.o >> >>> --- /dev/null >>> +++ b/drivers/soc/fsl/soc-vf610.c >> >>> +MODULE_DEVICE_TABLE(of, vf610_soc_bus_match); >> >>> +module_platform_driver(vf610_soc_driver); >> >> (The series starting at https://lkml.org/lkml/2015/5/10/131 would allow >> to use builtin_platform_driver() for built-in only code.) [...] >>> +MODULE_DESCRIPTION("Freescale VF610 SoC bus driver"); >>> +MODULE_LICENSE("GPL v2"); >> >> I think soc-vf610.o can only be built-in. But its code contains a few >> module specific macros. Was it perhaps intended for SOC_VF610 to be >> tristate? > > I too think that should be built-in.
Why? For a generic distro kernel it'd be unfortunate to not allow putting such a driver into an initrd, if needed early, or into the rootfs otherwise.
Regards, Andreas
> Did not have an intention of making > it tristate, however while using other drivers as references, the perhaps > unneccessary stuff crept in. > > The MODULE_* references can be removed along with the corresponding header > file. However that series has not been merged yet, so I can't use builtin_* > yet? [snip]
-- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)
| |