lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/11] Do not leak memory if qxl_release_list_add fails
    Date
    If the function fails reference counter to the object is not decremented
    causing leaks.
    This is hard to spot as it happens only on very low memory situations.

    Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
    ---
    qxl/qxl_ioctl.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/qxl/qxl_ioctl.c b/qxl/qxl_ioctl.c
    index afd7297..e8b5207 100644
    --- a/qxl/qxl_ioctl.c
    +++ b/qxl/qxl_ioctl.c
    @@ -122,8 +122,10 @@ static struct qxl_bo *qxlhw_handle_to_bo(struct qxl_device *qdev,
    qobj = gem_to_qxl_bo(gobj);

    ret = qxl_release_list_add(release, qobj);
    - if (ret)
    + if (ret) {
    + drm_gem_object_unreference_unlocked(gobj);
    return NULL;
    + }

    return qobj;
    }
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-05-27 12:21    [W:4.124 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site