lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf/x86/intel/cqm: Use proper data types
    Commit-ID:  b3df4ec4424f27e55d754cfe586195fecca1c4e4
    Gitweb: http://git.kernel.org/tip/b3df4ec4424f27e55d754cfe586195fecca1c4e4
    Author: Thomas Gleixner <tglx@linutronix.de>
    AuthorDate: Tue, 19 May 2015 00:00:51 +0000
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Wed, 27 May 2015 09:17:39 +0200

    perf/x86/intel/cqm: Use proper data types

    'int' is really not a proper data type for an MSR. Use u32 to make it
    clear that we are dealing with a 32-bit unsigned hardware value.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Acked-by: Matt Fleming <matt.fleming@intel.com>
    Cc: Kanaka Juvva <kanaka.d.juvva@intel.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>
    Cc: Will Auld <will.auld@intel.com>
    Link: http://lkml.kernel.org/r/20150518235149.919350144@linutronix.de
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    arch/x86/kernel/cpu/perf_event_intel_cqm.c | 4 ++--
    include/linux/perf_event.h | 2 +-
    2 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kernel/cpu/perf_event_intel_cqm.c b/arch/x86/kernel/cpu/perf_event_intel_cqm.c
    index 572582e..3e9a7fb 100644
    --- a/arch/x86/kernel/cpu/perf_event_intel_cqm.c
    +++ b/arch/x86/kernel/cpu/perf_event_intel_cqm.c
    @@ -18,7 +18,7 @@ static unsigned int cqm_l3_scale; /* supposedly cacheline size */

    struct intel_cqm_state {
    raw_spinlock_t lock;
    - int rmid;
    + u32 rmid;
    int cnt;
    };

    @@ -962,7 +962,7 @@ out:
    static void intel_cqm_event_start(struct perf_event *event, int mode)
    {
    struct intel_cqm_state *state = this_cpu_ptr(&cqm_state);
    - unsigned int rmid = event->hw.cqm_rmid;
    + u32 rmid = event->hw.cqm_rmid;
    unsigned long flags;

    if (!(event->hw.cqm_state & PERF_HES_STOPPED))
    diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
    index 248f782..0658002 100644
    --- a/include/linux/perf_event.h
    +++ b/include/linux/perf_event.h
    @@ -120,7 +120,7 @@ struct hw_perf_event {
    };
    struct { /* intel_cqm */
    int cqm_state;
    - int cqm_rmid;
    + u32 cqm_rmid;
    struct list_head cqm_events_entry;
    struct list_head cqm_groups_entry;
    struct list_head cqm_group_entry;

    \
     
     \ /
      Last update: 2015-05-27 12:21    [W:4.125 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site