lkml.org 
[lkml]   [2015]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/11] perf/x86: Improve HT workaround GP counter constraint
On Tue, May 26, 2015 at 04:33:42PM -0700, Andi Kleen wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
> > + */
> > + if (is_ht_workaround_enabled() && !cpuc->is_fake &&
>
> Could this function also check if at least one leaking event is
> scheduled somewhere? (e.g. from a global count)

You truncated one line too many:

+ if (is_ht_workaround_enabled() && !cpuc->is_fake &&
+ READ_ONCE(cpuc->excl_cntrs->exclusive_present))
+ gpmax /= 2;

Guess what that READ_ONCE() does? It checks if there's one such leaky
event on the current core.


\
 
 \ /
  Last update: 2015-05-27 10:21    [W:0.162 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site