Messages in this thread | | | Date | Wed, 27 May 2015 11:43:49 +0800 | From | "Zhang, Yanmin" <> | Subject | Re: [PATCH V2 3/3] n_gsm: wake up ldisc tty before using it |
| |
On 2015/5/27 11:02, Greg KH wrote: > On Wed, May 27, 2015 at 10:50:01AM +0800, Zhang, Yanmin wrote: >> Wake up ldisc device before calling its driver to access the device. >> >> Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com> >> >> --- >> >> drivers/tty/n_gsm.c | 40 +++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 39 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c >> index 2c34c32..40671fa 100644 >> --- a/drivers/tty/n_gsm.c >> +++ b/drivers/tty/n_gsm.c >> @@ -62,6 +62,7 @@ >> #include <linux/netdevice.h> >> #include <linux/etherdevice.h> >> #include <linux/gsmmux.h> >> +#include <linux/pm_runtime.h> >> >> static int debug; >> module_param(debug, int, 0600); >> @@ -555,6 +556,27 @@ static int gsm_stuff_frame(const u8 *input, u8 *output, int len) >> return olen; >> } >> >> +static int pm_runtime_get_sync_tty(struct tty_struct *tty) >> +{ >> + int ret = 0; >> + >> + /*Wakeup parent as tty itself doesn't enable runtime*/ > No spaces in your comment? I will add it.
> > Anyway, this is corrupted and can't be applied, please fix up your email > client and try it again... I check the patch by scripts/checkpatch.pl and everything seems good.
I use Thunderbird 31.7.0, the latest. It auto updates to the latest version. Perhaps some new config options changed something.
It seems email client converts some tab to space automatically.
Yanmin
| |