Messages in this thread | | | Date | Tue, 26 May 2015 19:41:18 -0700 | From | Greg KH <> | Subject | Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist |
| |
On Tue, May 26, 2015 at 10:54:01AM -0700, David Cohen wrote: > Hi, > > On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote: > > Greg KH <gregkh@linuxfoundation.org> writes: > > > > > If there are other bus drivers that do this, I'll go fix them up, > > > pointers to those files would be appreciated. > > > > git grep -E 'if .*\.p\W' found a couple of interesting candidates you > > might want to check out: > > > > drivers/i2c/i2c-core.c: if (unlikely(WARN_ON(!i2c_bus_type.p))) { > > drivers/i2c/i2c-core.c: if (unlikely(WARN_ON(!i2c_bus_type.p))) > > drivers/spmi/spmi.c: if (WARN_ON(!spmi_bus_type.p)) > > > > And this looks somewhat suspicious too, but could very well be OK for > > all I know (very close to nothing :) > > > > drivers/gpio/gpiolib-sysfs.c: if (!gpio_class.p) { > > drivers/gpio/gpiolib-sysfs.c: if (!gpio_class.p) > > I think we need a clear statement on how to proceed on this case.
Don't mess with bus->p. I can rename it to "do_not_touch_this_isnt_for_you" if people think that would make it more obvious that a private data structure shouldn't be messed with in any way. Outside of the driver core, you have no knowledge that even if it is a pointer, what that means with regards to anything.
thanks,
greg k-h
| |