lkml.org 
[lkml]   [2015]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 2/5] drivers: pwm: bcm-kona: Dont set polarity in probe
    Date
    From: Arun Ramamurthy <arunrama@broadcom.com>

    Omit setting the polarity to normal during probe and instead use the
    new pwmchip_add_inversed function to register a PWM chip with default
    polarity of inversed for all channels as this is the actual hardware
    default.

    Signed-off-by: Arun Ramamurthy <arunrama@broadcom.com>
    Reviewed-by: Ray Jui <rjui@broadcom.com>
    Signed-off-by: Scott Branden <sbranden@broadcom.com>
    Signed-off-by: Tim Kryger <tim.kryger@gmail.com>
    Signed-off-by: Jonathan Richardson <jonathar@broadcom.com>
    ---
    drivers/pwm/pwm-bcm-kona.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
    index 02bc048..32b3ec6 100644
    --- a/drivers/pwm/pwm-bcm-kona.c
    +++ b/drivers/pwm/pwm-bcm-kona.c
    @@ -266,18 +266,15 @@ static int kona_pwmc_probe(struct platform_device *pdev)
    return ret;
    }

    - /* Set smooth mode, push/pull, and normal polarity for all channels */
    - for (chan = 0; chan < kp->chip.npwm; chan++) {
    - value |= (1 << PWM_CONTROL_SMOOTH_SHIFT(chan));
    + /* Set push/pull for all channels */
    + for (chan = 0; chan < kp->chip.npwm; chan++)
    value |= (1 << PWM_CONTROL_TYPE_SHIFT(chan));
    - value |= (1 << PWM_CONTROL_POLARITY_SHIFT(chan));
    - }

    writel(value, kp->base + PWM_CONTROL_OFFSET);

    clk_disable_unprepare(kp->clk);

    - ret = pwmchip_add(&kp->chip);
    + ret = pwmchip_add_inversed(&kp->chip);
    if (ret < 0)
    dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);

    --
    1.7.9.5


    \
     
     \ /
      Last update: 2015-05-26 22:21    [W:4.113 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site