lkml.org 
[lkml]   [2015]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/37] perf tools: Remove redundant initialization of thread linkage members
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    A thread moves from a rb tree to a list, but can't be on both, because
    those linkage members are in a union. This is leftover from when I was
    debugging thread refcounting and had nuked that union.

    It is harmless duplication, as RB_CLEAR_NODE() does again what
    INIT_LIST_HEAD does.

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Borislav Petkov <bp@suse.de>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Don Zickus <dzickus@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-hmma9lmip6qlhzhgkhp9tzd1@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/thread.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
    index 16c28a37a9e4..28c4b746baa1 100644
    --- a/tools/perf/util/thread.c
    +++ b/tools/perf/util/thread.c
    @@ -54,7 +54,6 @@ struct thread *thread__new(pid_t pid, pid_t tid)

    list_add(&comm->list, &thread->comm_list);
    atomic_set(&thread->refcnt, 0);
    - INIT_LIST_HEAD(&thread->node);
    RB_CLEAR_NODE(&thread->rb_node);
    }

    @@ -70,7 +69,6 @@ void thread__delete(struct thread *thread)
    struct comm *comm, *tmp;

    BUG_ON(!RB_EMPTY_NODE(&thread->rb_node));
    - BUG_ON(!list_empty(&thread->node));

    thread_stack__free(thread);

    --
    2.1.0


    \
     
     \ /
      Last update: 2015-05-26 19:21    [W:8.475 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site