Messages in this thread | | | Date | Tue, 26 May 2015 09:12:48 -0700 | Subject | Re: [PATCHv1 0/2] Adding driver for Xilinx LogiCORE IP mailbox. | From | Moritz Fischer <> |
| |
On Mon, May 25, 2015 at 6:56 AM, Jingoo Han <jingoohan1@gmail.com> wrote: > On Monday, May 25, 2015 3:05 PM, Michal Simek wrote: >> On 05/22/2015 08:03 PM, Moritz Fischer wrote: >> > This patchset adds mailbox framework integration for the Xilinx LogiCORE IP >> > mailbox. The Xilinx LogiCORE IP mailbox is a fpga softcore that allows >> > interprocessor communication between AXI4 stream / memory mapped >> > processors. >> > >> > Changes from v0: >> > --------------------- >> > >> > - Several stylistic issues >> > - Dropped superfluous intr_mode member >> > - Really masking the IRQs on mailbox_shutdown >> > - No longer using polling by accident in non-IRQ mode >> > - Swapped doc and driver commits >> >> Changes update should be in every particular patch. >> Also v1 is used to the first version that's why this one should be v2.
Thanks for the feedback. I guess making the next round v2 would be less confusing, than restarting the entire patchset from v1?
> Right, I agree with Michal Simek's opinion. > If there are 'Changes update' in each patch, it makes people review > the patches more easily. In addition, normally, 'v0' is not used.
Sorry about that again. > > Best regards, > Jingoo Han > >> >> Thanks, >> Michal >
Thanks, Moritz
| |