Messages in this thread | | | Date | Tue, 26 May 2015 15:45:07 +0100 | From | Edward Cree <> | Subject | Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization |
| |
>> This breaks older compilers that can't initialize anon structures. > > How old ? Even gcc 3.1 says you can use unnamed struct/union fields and > 3.2 is the minimum version required to compile the kernel as mentioned > in the README. > > We could simply just name the structure, but I doubt this is the > only place in the kernel code where it's being used this way :)
This appears to be GCC bug #10676, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676> Says it was fixed in 4.6, but I believe the kernel supports GCCs much older than that (back to 3.2). I personally hit it on 4.4.7, the version shipped with RHEL6.6. So I think the kernel code has to change, probably by naming the structure.
| |