Messages in this thread | | | Date | Tue, 26 May 2015 16:34:55 +0200 | Subject | Re: [oss-security] Re: [PATCH v2 4/4] ozwpan: unchecked signed subtraction leads to DoS | From | "Jason A. Donenfeld" <> |
| |
On Tue, May 26, 2015 at 4:06 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > You sure do like wrapping to a high value and testing the result for > wrapping instead of validating before doing the subtraction...
I do indeed. It seems like asking "did it overflow?" is more straight-forward and easier to read than trying to come up with the necessary conditions to check for "will it overflow?". Personal preference, I guess.
| |