lkml.org 
[lkml]   [2015]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver
From
Date
> > +
> > +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */
> > +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */
> > +#define UNIPHIER_UART_LCR_SHIFT 8
>
> Indentation problem, needs to be fixed.

If you are going to review a patch set at least look at the previous
reviews - the indentation was already discussed and is done that way to
show (as many drivers do) which are fields for which registers

> > +static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
> > +{
> > + int valshift = 0;
>
> Perhaps unsigned int?

Why ? even if it mattered gcc is already realising that the value can
only be 0 or 8 and will be generating whatever works best for that.


Alan




\
 
 \ /
  Last update: 2015-05-26 16:41    [W:0.062 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site