Messages in this thread | | | Subject | Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver | From | Alan Cox <> | Date | Tue, 26 May 2015 15:28:38 +0100 |
| |
> > + > > +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control Register */ > > +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register */ > > +#define UNIPHIER_UART_LCR_SHIFT 8 > > Indentation problem, needs to be fixed.
If you are going to review a patch set at least look at the previous reviews - the indentation was already discussed and is done that way to show (as many drivers do) which are fields for which registers
> > +static unsigned int uniphier_serial_in(struct uart_port *p, int offset) > > +{ > > + int valshift = 0; > > Perhaps unsigned int?
Why ? even if it mattered gcc is already realising that the value can only be 0 or 8 and will be generating whatever works best for that.
Alan
| |