lkml.org 
[lkml]   [2015]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning
Btw, the subject should say "fix endian bug".  "silence" means that
their is a warning and possible some messy code but no runtime bug.

On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
> On 25/05/15 13:35, Dan Carpenter wrote:
> > This is also wrong then.
> >
> > regards,
> > dan carpenter
> Hi Dan,
>
> Yes, you are right. It is the next sparse warning in line for that file.
> Including the fix for that, the patch would be as showed below.
>
> There are similar endianness warnings for other variables in that file,
> like the FIXME in last line of the patch. But keeping in mind the rule
> 'one thing per patch' I guess this should be fixed in other patche/s, right?

The one thing per patch rule is a bit fuzzy. It depends on how you sell
it a bit. I wouldn't mind if you fixed the whole function at once. Or
even all then endian bugs in a file if the patch wasn't too complicated.

But this is also acceptable to fix one struct member so send your
proposed patch.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-05-26 16:41    [W:0.049 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site