Messages in this thread | | | Date | Tue, 26 May 2015 16:28:14 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH v2 3/8] core: platform: wakeup the parent before trying any driver operations |
| |
On Mon, May 25, 2015 at 01:36:43PM -0400, Alan Stern wrote: > On Mon, 25 May 2015, Andy Shevchenko wrote: > > > From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > > > If the parent is still suspended when a driver probe, > > remove or shutdown is attempted, the result may be a > > failure. > > > > For example, if the parent is a PCI MFD device that has been > > suspended when we try to probe our device, any register > > reads will return 0xffffffff. > > > > To fix the problem, making sure the parent is always awake > > before using driver probe, remove or shutdown. > > > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/base/platform.c | 21 ++++++++++++++++++++- > > Why make the changes here rather than in dd.c? Is there something > special about platform devices?
There isn't. That would definitely be better.
Thanks Alan,
-- heikki
| |