Messages in this thread | | | Subject | Re: [PATCH] RDMA/ocrdma: remove unneeded tests | From | Doug Ledford <> | Date | Tue, 26 May 2015 08:45:10 -0400 |
| |
On Thu, 2015-05-21 at 22:07 +0200, Laurent Navet wrote: > The same code is executed regardless status value, so these tests can > be removed. > Fix Coverity CID 1271151 and 1268788
Thanks, applied for 4.2.
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com> > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index 0c9e959..e748090 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct ocrdma_dev *dev, > upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa); > } > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > - if (status) > - goto mbx_err; > -mbx_err: > kfree(cmd); > return status; > } > @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq, > (eq[i].aic_obj.prev_eqd * 65)/100; > } > status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd); > - if (status) > - goto mbx_err; > -mbx_err: > kfree(cmd); > return status; > }
-- Doug Ledford <dledford@redhat.com> GPG KeyID: 0E572FDD
[unhandled content-type:application/pgp-signature] | |