Messages in this thread | | | Date | Mon, 25 May 2015 23:22:20 +0200 | From | Richard Weinberger <> | Subject | Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type |
| |
Am 25.05.2015 um 23:14 schrieb Shailendra Verma: > Hello Richard, > > I will separate both the changes and will send the patches to you. > > What issue does this fix? IOW why is assigning 1 wrong? > >>>>> Yes, you are correct. There will be no issue in assigning 1 to the variable. But according to coding guidelines we should only use true/false for bool type variables.
Really? I don't see this in Documentation/CodingStyle and checkpatch.pl does not bark either. IMHO it is a matter of taste. But the individual maintainer has to decide. :-)
Thanks, //richard
P.s: Please don't crop the list of CC when replying.
| |