lkml.org 
[lkml]   [2015]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] atm:he - Do not initialise statics to 0.
From
From: Shailendra Verma <shailendra.capricorn@gmail.com>
Date: Tue, 26 May 2015 01:23:53 +0530

> Static variables are initialised to 0 by GCC.
> Fixes the following checkpatch error:
> ERROR: do not initialise statics to 0 or NULL
> FILE: drivers/atm/he.c:120:
> static bool sdh = 0;
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>

true is not necessarily '1' and false is not necessarily '0',
therefore the correct fix would be to assign 'false' to this variable.

Furthermore you've submitted this in such a way that it cannot be
applied alongside the other atm:he patch you submitted.

This is why when you submit multiple patches to the same file, you
must group them and submit them relative to eachother and in a
specific order.


\
 
 \ /
  Last update: 2015-05-25 22:41    [W:0.051 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site