lkml.org 
[lkml]   [2015]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers:usb:fsl: Replace macros with enumerated type
On Mon, May 25, 2015 at 11:41:34AM +0530, Nikhil Badola wrote:
> Replace macros with enumerated type to represent usb ip controller
> version
>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
> Depends on "drivers: usb :fsl: Add support for USB controller version-2.5"
>
> include/linux/fsl_devices.h | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
> index 2a2f56b..035ead7 100644
> --- a/include/linux/fsl_devices.h
> +++ b/include/linux/fsl_devices.h
> @@ -20,11 +20,6 @@
> #define FSL_UTMI_PHY_DLY 10 /*As per P1010RM, delay for UTMI
> PHY CLK to become stable - 10ms*/
> #define FSL_USB_PHY_CLK_TIMEOUT 10000 /* uSec */
> -#define FSL_USB_VER_OLD 0
> -#define FSL_USB_VER_1_6 1
> -#define FSL_USB_VER_2_2 2
> -#define FSL_USB_VER_2_4 3
> -#define FSL_USB_VER_2_5 4
>
> #include <linux/types.h>
>
> @@ -52,6 +47,14 @@
> *
> */
>
> +enum fsl_usb2_controller_ver {
> + FSL_USB_VER_OLD,
> + FSL_USB_VER_1_6,
> + FSL_USB_VER_2_2,
> + FSL_USB_VER_2_4,
> + FSL_USB_VER_2_5,

Don't you need to specify the value here just to be "sure" the compiler
gets it correct, and so that someone knows they can't add a new value in
the middle?

And why didn't you cc: the linux-usb mailing list?

greg k-h


\
 
 \ /
  Last update: 2015-05-25 18:41    [W:0.051 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site