lkml.org 
[lkml]   [2015]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall
On Fri, May 22, 2015 at 09:08:45AM -0700, David Cohen wrote:
> Hi,
>
> On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote:
> > Phy drivers and the ulpi interface providers depend on the
> > registeration of the ulpi bus. Ulpi registers the bus in
> > module_init(). This could result in a load order issue, i.e.
>
> It's still not an issue :(
> I'd say "unnecessary probe delays".
>
> But of cource it's Felipe's call :) Description looks better now.
>
> BR, David
>
> > ulpi phy drivers or the ulpi interface providers loading
> > before the bus registeration.
> >
> > This patch fixes this load order issue by putting ulpi_init
> > in subsys_initcall().
> >
> > Reported-by: Zhuo Qiuxu <qiuxu.zhuo@intel.com>
> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Adding Felipe. FWIW, my ACK in any case:

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


Thanks,

--
heikki


\
 
 \ /
  Last update: 2015-05-25 14:21    [W:0.059 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site