Messages in this thread | | | Date | Sun, 24 May 2015 11:13:28 -0500 | From | Timur Tabi <> | Subject | Re: [PATCH v2 6/7] Watchdog: introduce ARM SBSA watchdog driver |
| |
Fu Wei wrote: > in the first timeout, just panic() maybe not enough, in [RFC] > version of my patchset, I offer some option as "preaction" to use, but > for simplifying the first version of driver, I have deleted them. > but at least, panic() is far more useful than a simple reset. at > least, it can provide the context of the crashed system to admin.
My point is that there is very little difference between
1) calling panic() on pre-timeout 2) calling panic() on timeout
In both cases, the system will panic. The watchdog API says that the system should reset when a timeout occurs, so you cannot call panic() before the timeout expires.
> If you want to warn user space, that will make driver more > complicated, I don't think that is a good choose for a first version. > but we can find a way to improve this later
In my opinion, this "first version" is not useful. I would like to see a pre-timeout feature that does not panic or reset when a pre-timeout occurs.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.
| |