lkml.org 
[lkml]   [2015]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC v1] tree-wide: remove "select FW_LOADER" uses
From
On Sat, May 23, 2015 at 1:02 AM, Luis R. Rodriguez <mcgrof@suse.com> wrote:
> On Fri, May 22, 2015 at 3:33 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>> On Sat, May 23, 2015 at 12:22:00AM +0200, Luis R. Rodriguez wrote:
>>> Kind of, the issue actually was a new component which depends on FW_LOADER
>>> and has crypto dependencies. Since the qat crypto driver selects FW_LOADER
>>> but also has a set of crypto dependencies that creates a recursive dependency
>>> loop.
>>
>> Actually, how about making FW_SIG select FW_LOADER instead of
>> depending on it? I think this should break the cycle.
>
> Indeed, it does. Kind of odd, but works - and well if others run into
> the recursive issue then we have two diverging solutions now:
>
> a) Either swap all "select FOO" to "depends on FOO" or,
> b) Change the offending "depends on FOO" to "select FOO"
>
> So sticking to one seems to make Kconfig happy for recursive
> dependency solving for now...

Yes, that works, too.

Perhaps Kconfig should start warning if it encounters a symbol
that is both selected and being depended on, even without detecting an
explicit recursive dependency?
That's gonna give tons of warnings, though...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-05-23 09:41    [W:0.080 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site