lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/6] iio: light: Updated Vishay Capella cm32181 ambient light sensor driver. - Renamed company name. - Removed cm32181_reg. - Removed white space. - Removed unused include files. - Updated macro definitions. - Renamed cm32181_chip pointer to c
From
On Fri, May 22, 2015 at 4:56 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, May 21, 2015 at 05:30:40PM -0700, Kevin Tsai wrote:
>> Signed-off-by: Kevin Tsai <ktsai@capellamicro.com>
>> ---
>
> Your whole changelog ended up in the Subject line :(

Hi Kevin,

Few comments:

1) Please also add a cover letter. Use --cover-letter parameter of git
format-patch.
2) Please create a patch for each logical change. Your current 1/6
patch should be
split in several small patches:
* 1/6 iio: light: cm32181: Update company name
* 2/6 iio: light: cm32181: Remove unused include files
* etc.
3) Please use specific wordings for commit subject. A subject like this:

"Updated Vishay Capella cm32181 ambient light sensor driver" doesn't say much.

thanks,
Daniel.


\
 
 \ /
  Last update: 2015-05-22 09:21    [W:0.081 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site