lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] MIPS: MSA: bugfix - disable MSA during thread switch correctly
On 05/22/2015 02:38 AM, Ralf Baechle wrote:
> Just move the call to finish_arch_switch().

It might be a problem later, then a correct MSA partiton starts working.
It should be tight to saving MSA registers in that case.

> Your rewrite also dropped the if (cpu_has_msa) condition from
> disable_msa() probably causing havoc on lots of CPUs which will likely
> not decode the set bits of the MFC0/MTC0 instructions thus end up
> accessing Config0. Ralf

Right before this chunk of code there is a saving MSA registers. Does it
causing a havoc or else?

May I ask you to look into switch_to macro to figure out how "if
(cpu_has_msa)" check works in this case?

- Leonid.



\
 
 \ /
  Last update: 2015-05-22 21:21    [W:0.104 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site