lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF


On 22/05/15 14:21, Arnd Bergmann wrote:
> On Friday 22 May 2015 12:53:44 Srinivas Kandagatla wrote:
>> Thanks for looking at this patch.
>>
>> On 22/05/15 08:24, Arnd Bergmann wrote:
>>> On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote:
>>>>
>>>> config SND_SOC_LPASS_CPU
>>>> tristate
>>>> + depends on OF
>>>> select REGMAP_MMIO
>>>>
>>>> config SND_SOC_LPASS_PLATFORM
>>>> tristate
>>>> + depends on OF
>>>> select REGMAP_MMIO
>>>>
>>>> config SND_SOC_LPASS_IPQ806X
>>>>
>>>
>>> Could you instead make the drivers compile without OF being set?
>>>
>>> I see that patch 7 and 8 introduces another two options doing
>>>
>>>
>>> +config SND_SOC_LPASS_APQ8016
>>> + tristate
>>> + depends on SND_SOC_QCOM
>>> + select SND_SOC_LPASS_CPU
>>> + select SND_SOC_LPASS_PLATFORM
>>> +
>>>
>>> +config SND_SOC_APQ8016_SBC
>>> + tristate "SoC Audio support for APQ8016 SBC platforms"
>>> + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
>>> + select SND_SOC_LPASS_APQ8016
>>> + help
>>>
>>> so you get an obvious build failure here when SND_SOC_APQ8016_SBC
>>> gets selected with COMPILE_TEST on a platform that does not support OF.
>>>
>>
>> Yes, this would fail.
>> I think moving of_device_id structures in drivers under #ifdef CONFIG_OF
>> and removing the depends on OF would fix it.
>>
>
> Why?

Yes, you are correct we don't need the ifdef's anymore. I will send a
fixup patch on top of what Mark has already applied.

--srini
>
> Arnd
>
>


\
 
 \ /
  Last update: 2015-05-22 16:21    [W:0.048 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site