Messages in this thread | | | Date | Fri, 22 May 2015 17:56:12 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] zram: check compressor name before setting it |
| |
On (05/22/15 10:31), Marcin Jabrzyk wrote: > Zram sysfs interface was not making any check of > proper compressor name when setting it. > Any name is accepted, but further tries of device > creation would end up with not very meaningfull error. > eg. > > echo lz0 > comp_algorithm > echo 200M > disksize > echo: write error: Invalid argument >
no.
zram already complains about failed comp backend creation. it's in dmesg (or syslog, etc.):
"zram: Cannot initialise %s compressing backend"
second, there is not much value in exposing zcomp internals, especially when the result is just another line in dmesg output.
-ss
| |