lkml.org 
[lkml]   [2015]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 2/3] dell-rbtn: Export notifier for other kernel modules
Date
On Saturday 23 May 2015 00:45:57 Dmitry Torokhov wrote:
> On Thu, May 14, 2015 at 3:54 AM, Pali Rohár <pali.rohar@gmail.com>
> wrote:
> > @@ -328,7 +408,9 @@ static void rbtn_notify(struct acpi_device
> > *device, u32 event)
> >
> > static int __init rbtn_init(void)
> > {
> >
> > - return acpi_bus_register_driver(&rbtn_driver);
> > + /* ignore errors so module always loads and exports needed
> > functions */ + acpi_bus_register_driver(&rbtn_driver);
> > + return 0;
>
> Ahem, and if it fails for some reason and you try to unload the
> module what will happen when you call
> acpi_bus_unregister_driver(&rbtn_driver) in rbtn_exit()?\
>
> Thanks.

I'm thinking about using symbol_request() in dell-laptop.c (instead hard
dependency) and then not ignoring error here... It could fix this
problem.

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-05-23 03:21    [W:0.178 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site