lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] clocksource: Add Pistachio clocksource-only driver
On Thu, 21 May 2015, Ezequiel Garcia wrote:
> +static cycle_t clocksource_read_cycles(struct clocksource *cs)
> +{
> + u32 counter, overflw;
> + unsigned long flags;
> +
> + raw_spin_lock_irqsave(&lock, flags);

Hmm. Is that lock really necessary to read that counter? The
clocksource is global. And if its actually used for timekeeping, the
lock can get heavy contended.

> + overflw = gpt_readl(TIMER_CURRENT_OVERFLOW_VALUE, 0);
> + counter = gpt_readl(TIMER_CURRENT_VALUE, 0);
> + raw_spin_unlock_irqrestore(&lock, flags);
> +
> + return ~(cycle_t)counter;
> +}

Thanks,

tglx


\
 
 \ /
  Last update: 2015-05-22 00:41    [W:0.114 / U:1.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site