Messages in this thread Patch in this message | | | Date | Thu, 21 May 2015 12:07:13 -0400 (EDT) | Subject | Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter | From | David Miller <> |
| |
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> Date: Thu, 21 May 2015 13:10:49 +0000
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > index 263cb40..b45570f 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > @@ -158,6 +158,10 @@ module_param(allow_unsupported_sfp, uint, 0); > MODULE_PARM_DESC(allow_unsupported_sfp, > "Allow unsupported and untested SFP+ modules on 82599-based adapters"); > > +static unsigned int disable_hw_vlan_filter; > +module_param(disable_hw_vlan_filter, uint, 0); > +MODULE_PARM_DESC(disable_hw_vlan_filter, "Disable HW VLAN filter");
Sorry, module parameters like this are not allowed.
You must use a generic, portable interface, to configure networking device settings.
Otherwise every other driver that wants to do something similar will have yet another module option with a different name, and every user will suffer because they will need to learn a different mechanism to perform this configuration for every driver.
| |