Messages in this thread | | | Date | Thu, 21 May 2015 08:14:08 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/7] time: Rework debugging variables so they aren't global |
| |
* John Stultz <john.stultz@linaro.org> wrote:
> Ingo suggested that the timekeeping debugging variables > recently added should not be global, and should be tied > to the timekeeper's read_base. > > Thus this patch implements that suggestion. > > This version is differnet from the earlier versions
s/differnet/ different
> as it keeps the variables in the timekeeper structure > rather then in the tkr.
> + * @last_warning: Warning ratelimiter (DEBUG_TIMEKEEPING) > + * @underflow_seen: Underflow warning flag (DEBUG_TIMEKEEPING) > + * @overflow_seen: Overflow warning flag (DEBUG_TIMEKEEPING) > * > * Note: For timespec(64) based interfaces wall_to_monotonic is what > * we need to add to xtime (or xtime corrected for sub jiffie times) > @@ -106,6 +109,18 @@ struct timekeeper { > s64 ntp_error; > u32 ntp_error_shift; > u32 ntp_err_mult; > +#ifdef CONFIG_DEBUG_TIMEKEEPING > + long last_warning; > + /* > + * These simple flag variables are managed > + * without locks, which is racy, but ok since > + * we don't really care about being super > + * precise about how many events were seen, > + * just that a problem was observed.
s/but ok since/ but they are ok since
Thanks,
Ingo
| |