Messages in this thread | | | Date | Thu, 21 May 2015 15:14:29 +0200 | From | Ralf Baechle <> | Subject | Re: [PATCH] mips: irq: Use DECLARE_BITMAP |
| |
On Wed, May 20, 2015 at 05:44:54AM -0700, Joe Perches wrote:
> Use the generic mechanism to declare a bitmap instead of unsigned long. > > This could fix an overwrite defect of whatever follows irq_map. > > Not all "#define NR_IRQS <value>" are a multiple of BITS_PER_LONG so > using DECLARE_BITMAP allocates the proper number of longs required > for the possible bits. > > For instance: > > arch/mips/include/asm/mach-ath79/irq.h:#define NR_IRQS 51 > arch/mips/include/asm/mach-db1x00/irq.h:#define NR_IRQS 152 > arch/mips/include/asm/mach-lantiq/falcon/irq.h:#define NR_IRQS 328
This only matters to user of the allocate_irqno() API and there is only on such platform, the IP27 which fortunately uses a NR_IRQS value that is a multiple of 64, so no impact.
Thanks anyway!
Ralf
| |