Messages in this thread | | | Date | Thu, 21 May 2015 12:52:13 +0200 | From | Roger Pau Monné <> | Subject | Re: [PATCH v2 1/2] driver: xen-blkfront: move talk_to_blkback to a more suitable place |
| |
El 20/05/15 a les 15.10, Bob Liu ha escrit: > The major responsibility of talk_to_blkback() is allocate and initialize the > request ring and writes the ring info stuff out. ^ write ^ to xenstore. > But this work should be done after backend entered 'XenbusStateInitWait' as > defined in the protocol file. > See xen/include/public/io/blkif.h in XEN git tree: > Front Back > ================================= ===================================== > XenbusStateInitialising XenbusStateInitialising > o Query virtual device o Query backend device identification > properties. data. > o Setup OS device instance. o Open and validate backend device. > o Publish backend features and > transport parameters. > | > | > V > XenbusStateInitWait > > o Query backend features and > transport parameters. > o Allocate and initialize the > request ring. > > There is no problem with this yet, but it is an violation of the design and > furthermore it would not allow frontend/backend to negotiate 'multi-page' and > 'multi-queue' features. > > Changes in v2: > - Re-write the commit message to be more clear. > > Signed-off-by: Bob Liu <bob.liu@oracle.com>
With that fixed:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Roger.
| |