lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/5] soc: mediatek: Add infracfg misc driver support
    From
    Date
    Just a nit: an unneeded macro.

    On Wed, 2015-05-20 at 16:18 +0200, Sascha Hauer wrote:

    > --- a/drivers/soc/mediatek/Kconfig
    > +++ b/drivers/soc/mediatek/Kconfig

    > +config MTK_INFRACFG
    > + bool "MediaTek INFRACFG Support"
    > + depends on ARCH_MEDIATEK
    > + select REGMAP
    > + help
    > + Say yes here to add support for the MediaTek INFRACFG controller. The
    > + INFRACFG controller contains various infrastructure registers not
    > + directly associated to any device.
    > +

    > --- a/drivers/soc/mediatek/Makefile
    > +++ b/drivers/soc/mediatek/Makefile

    > +obj-$(CONFIG_MTK_INFRACFG) += mtk-infracfg.o

    > --- /dev/null
    > +++ b/drivers/soc/mediatek/mtk-infracfg.c

    > +#include <linux/module.h>

    > +MODULE_LICENSE("GPL v2");

    MTK_INFRACFG was changed from tristate to bool in this version.

    Note that for built-in code MODULE_LICENSE() will be effectively
    preprocessed away. So you can drop that macro, and the include of
    linux/module.h too. (I did a quick compile to see if nothing else
    requires module.h, and it compiled cleanly without that include.)

    Thanks,


    Paul Bolle



    \
     
     \ /
      Last update: 2015-05-21 10:41    [W:2.362 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site