Messages in this thread | | | Subject | Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component | From | Paul Bolle <> | Date | Thu, 21 May 2015 09:16:10 +0200 |
| |
On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: > By the way, as far as I can see, this (new) module can only be loaded > manually (or via scripts). Is that what people want?
This comment wasn't well thought through. So I hand another look at the code of usf-qcom.
I noticed that the single thing ufs-qcom exports is "struct ufs_hba_qcom_vops". But that's unused in next-20150520: $ git grep -nw ufs_hba_qcom_vops drivers/scsi/ufs/ufs-qcom.c:999: * struct ufs_hba_qcom_vops - UFS QCOM specific variant operations drivers/scsi/ufs/ufs-qcom.c:1004:static const struct ufs_hba_variant_ops ufs_hba_qcom_vops = { drivers/scsi/ufs/ufs-qcom.c:1016:EXPORT_SYMBOL(ufs_hba_qcom_vops);
So it's not used by code outside of ufs-qcom.c. Probably because it can't actually be used by outside code. It's not mentioned in any public header and it's even static!
Am I missing something obvious here? Because ufs-qcom currently looks pointless to me, and I actually see little reason to even have it in the mainline tree.
Paul Bolle
| |