Messages in this thread | | | Subject | Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes | From | Joe Perches <> | Date | Thu, 21 May 2015 19:46:18 -0700 |
| |
On Thu, 2015-05-21 at 18:04 -0400, Michael Shuey wrote: > That's a task (of many) I've been putting on the back burner until the code > is cleaner. It's also a HUGE change, since there are debug macros > everywhere, and they all check a #define'd mask to see if they should fire, > and the behavior is likely governed by parts of the lustre user land tools > as well. > > Suggestions are welcome. Do other parts of the linux kernel define complex > debugging macros like these, or is this a lustre-ism? Any suggestions on > how to handle this more in line with existing drivers?
Yes, many other bits of code use custom debugging macros.
A good general form is to add a either a generic level or bitmask macro and use a single entry like:
my_dbg([optional_ptr,] <level|bitmap>, fmt, ...)
so that <level|bitmap> can be tested against some variable set by MODULE_PARM_DESC controls.
So, CNETERR(...) might be lustre_dbg(ptr, NETERR, fmt, ...)
though I don't know what use the ptr might have.
| |