Messages in this thread | | | Date | Thu, 21 May 2015 02:45:35 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool |
| |
On Wed, May 20, 2015 at 07:44:39PM +0200, Stephan Mueller wrote: > > + if (unlikely(nonblocking_pool.initialized == 0)) { > + do { > + rc = wait_event_interruptible(urandom_init_wait, > + nonblocking_pool.initialized); > + } while (rc == -ERESTARTSYS);
This is just a convoluted way of doing an uninterruptible sleep. Either make it uninterruptible or allow the function to return an error.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |